Skip to content

fix: update homepage cursor state #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donganhxauxi wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: update homepage cursor state #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/containers/Homepage/HomeHero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ const _HomeHero = ({ randomGenerativeToken, articles }: HomeHeroProps) => {
const nbObjkts = randomGenerativeTokenWithDups?.objkts.length || 0
return Math.floor(((cursor + 1) * 100) / nbObjkts)
}, [cursor, randomGenerativeTokenWithDups?.objkts.length])

const changeCursorHandler = () => {
const randomGenerativeTokenWithDupsIterations =
randomGenerativeTokenWithDups?.objkts
if (!randomGenerativeTokenWithDupsIterations) return
setCursor((oldCursor) =>
oldCursor === randomGenerativeTokenWithDupsIterations.length - 1
? 0
: oldCursor + 1
)
}
return (
<>
<div className={style.container}>
Expand All @@ -78,7 +89,8 @@ const _HomeHero = ({ randomGenerativeToken, articles }: HomeHeroProps) => {
{randomGenerativeTokenWithDups && (
<RandomIterativeCycler
generativeToken={randomGenerativeTokenWithDups}
onChangeCursor={setCursor}
cursor={cursor}
onChangeCursor={changeCursorHandler}
/>
)}
</div>
Expand Down
16 changes: 5 additions & 11 deletions src/containers/Homepage/RandomIterativeCycler.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,16 @@ type CalculateItemPositionAndOpacity = (data: {

interface RandomIterativeCyclerProps {
generativeToken: GenerativeToken
onChangeCursor: (cursorPos: number) => void
cursor: number
onChangeCursor: () => void
}

const maxTimeSec = 5
const _RandomIterativeCycler = ({
generativeToken,
cursor,
onChangeCursor,
}: RandomIterativeCyclerProps) => {
const [cursor, setCursor] = useState(0)
const [counterInSec, setCounterInSec] = useState(0)
const calculateItemPositionAndOpacity =
useCallback<CalculateItemPositionAndOpacity>(
Expand Down Expand Up @@ -83,17 +84,10 @@ const _RandomIterativeCycler = ({
}, [])
useEffect(() => {
if (counterInSec > maxTimeSec) {
setCursor((oldCursor) => {
return oldCursor === generativeToken.objkts.length - 1
? 0
: oldCursor + 1
})
onChangeCursor()
setCounterInSec(0)
}
}, [counterInSec, generativeToken.objkts.length])
useEffect(() => {
onChangeCursor(cursor)
}, [cursor, onChangeCursor])
}, [counterInSec, onChangeCursor])
return (
<div className={style.cycler}>
{generativeToken.objkts?.map((objkt, idx) => {
Expand Down