Skip to content

chore: Clean hash urls#616

Merged
ashwin1111 merged 1 commit intomasterfrom
remove-hash-urls-to-web-app-final
Feb 24, 2026
Merged

chore: Clean hash urls#616
ashwin1111 merged 1 commit intomasterfrom
remove-hash-urls-to-web-app-final

Conversation

@shubham-fyle
Copy link
Contributor

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Test expectations updated to reflect a change in admin expense view URL format. Two test cases were modified to expect URLs without the leading hash fragment (from .../#/view_expense/... to .../view_expense/...). Lines changed: 2 added, 2 removed. No functional code alterations.

Changes

Cohort / File(s) Summary
Test Expectations Update
tests/test_xero/test_tasks.py
Updated two test assertions to expect admin expense view URLs without the leading hash fragment, changing URL format from /#/view_expense/ to /view_expense/.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hash fragment vanishes in the night,
Tests align with URLs made right,
Two little tweaks, so clean and bright,
The rabbit hops with pure delight! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description only contains a ClickUp link with no meaningful explanation of the changes, making it too vague to convey information about the changeset. Add a brief description explaining what the PR accomplishes, such as 'Removes hash fragments from admin expense view URLs in test expectations'.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Clean hash urls' directly relates to the changeset, which removes hash fragments from URLs in test expectations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch remove-hash-urls-to-web-app-final

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
apps
   exceptions.py54983%30, 42, 67, 73, 91, 104, 122–124
apps/fyle
   actions.py141795%92, 314, 353–357
   enums.py270100% 
   helpers.py133894%61, 225, 232–235, 238–239
   models.py2701096%375–377, 381–383, 402, 406, 462, 589, 611, 717
   queue.py480100% 
   serializers.py210100% 
   signals.py240100% 
   tasks.py4392395%146–147, 154–156, 346, 356–365, 373, 377, 701–703, 721–738, 750–752
   views.py790100% 
apps/internal
   tasks.py53787%41–46, 73
apps/mappings
   actions.py36489%46–47, 50–51
   constants.py20100% 
   exceptions.py1041288%38–40, 43–44, 47–48, 55–57, 60–61
   helpers.py21767%17–21, 28–30
   models.py310100% 
   queue.py351654%57–123
   schedules.py120100% 
   serializers.py100100% 
   signals.py80989%39–40, 117–119, 144–150
   tasks.py35197%83
   utils.py342041%46–113
   views.py320100% 
apps/tasks
   enums.py150100% 
   models.py630100% 
   serializers.py60100% 
   views.py90100% 
apps/users
   helpers.py120100% 
   models.py530100% 
apps/workspaces
   actions.py1504173%141–142, 163–172, 201–273
   email.py360100% 
   helpers.py45198%25
   models.py136199%127
   permissions.py20195%23
   queue.py41685%60–64, 87
   serializers.py260100% 
   signals.py280100% 
   tasks.py124298%157–158
   utils.py1003763%94–231, 263–264
   views.py1090100% 
apps/workspaces/apis/advanced_settings
   serializers.py69593%163, 166, 172, 178, 181
   triggers.py120100% 
   views.py110100% 
apps/workspaces/apis/clone_settings
   helpers.py90100% 
   serializers.py440100% 
   views.py22291%14–16
apps/workspaces/apis/errors
   serializers.py200100% 
   views.py190100% 
apps/workspaces/apis/export_settings
   helpers.py72396%132–134
   serializers.py94694%211, 214, 217, 224, 231, 240
   triggers.py190100% 
   views.py110100% 
apps/workspaces/apis/import_settings
   serializers.py79396%226, 229, 232
   triggers.py63395%36–37, 89
   views.py110100% 
apps/workspaces/templatetags
   custom_filters.py50100% 
apps/xero
   actions.py30873%22–32
   exceptions.py1412582%54–55, 98–135, 163–169, 181, 189–195
   models.py216598%40–44, 55, 376, 395
   queue.py112199%37
   serializers.py150100% 
   tasks.py4939182%145–169, 182, 274–278, 289–290, 301, 331, 354–355, 463–467, 478–479, 534, 561–562, 701, 758–760, 764–765, 906–911, 945–955, 958–969, 973–1004, 1037–1041, 1068–1072, 1091, 1098–1102
   utils.py3382692%100, 139–184, 215, 319, 328–349, 364, 752, 831, 882
   views.py960100% 
workers
   actions.py260100% 
   helpers.py460100% 
   worker.py56395%76–77, 124
TOTAL482340392% 

Tests Skipped Failures Errors Time
308 0 💤 0 ❌ 0 🔥 1m 33s ⏱️

@github-actions
Copy link


Diff Coverage
Diff: origin/master..HEAD, staged and unstaged changes

No lines with coverage information in this diff.

@Dimple16 Dimple16 requested a review from ashwin1111 February 24, 2026 06:46
@ashwin1111 ashwin1111 merged commit d0047ec into master Feb 24, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants