feat: "Optimize" image directories by moving unused bin files to a backup dir#100
Draft
feat: "Optimize" image directories by moving unused bin files to a backup dir#100
Conversation
g026r
force-pushed
the
optimize_images
branch
2 times, most recently
from
4b2add3 to
2d77cdc
Compare
TODO: should generate/regenerate/add/edit copy files over from bak # Conflicts: # go.mod # go.sum # Conflicts: # go.mod # pkg/ui/app.go
…at I can find it again if I turn those back on.
g026r
force-pushed
the
optimize_images
branch
from
d4af22e to
4aa0324
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does:
FAT isn't a terribly efficient file system when it comes to directories with a large number of files. For something like GB/GBC or GBA, where a full library set of either is roughly 3,000 images, this can add a noticeable lag to cartridge recognition due to it having to first parse the file allocation table in order to determine if an image is present.
Why would I want it
Depending on the speed of your SD card, this lag can be up to a second or two when selecting
Run Cartridge. If you aren't really adding any new cartridges to your library & you aren't using the library browser option, there's no need to keep all those images in the directory.Why wouldn't I want it
You're constantly adding new games to your library. You're mostly playing non-Game Boy systems, where the recognition lag is significantly lower. You just don't care about that extra time.
Does it get rid of all the lag?
Unfortunately no. Either the signature algorithm or looking up the correct game information is a bit slow on the Pocket, so those same systems will be improved but never be as a fast as e.g. the Neo Geo Pocket.
Still left to do: