Fix navbar dropdowns#68
Open
muan wants to merge 2 commits intog0v:masterfrom
Open
Conversation
- Dropdown buttons are not links, a without href isn't tabble - Add aria-haspopup to indicate dropdown - #projects doesn't exist, aria-labelledby has no effect - Icon isn't useful for sr's so should be hidden * Would've added aria-expanded as well, but doesn't look like it's quite as easy to add a script to toogle the attribute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<a>withouthrefisn't tabbablearia-haspopupto indicate dropdown#projectsdoesn't exist,aria-labelledbyhas no effectaria-expandedas well, but doesn't look like it's quite as easy to add a script to toggle the attribute 😔Before
After
⭐⭐⭐⭐