Skip to content

Ollama Pull Model bug fix #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
umama-rahman1 merged 4 commits into from
Mar 3, 2025
Merged

Ollama Pull Model bug fix #21

umama-rahman1 merged 4 commits into from
Mar 3, 2025

Conversation

@umama-rahman1
Copy link
Contributor

@umama-rahman1 umama-rahman1 commented Feb 24, 2025 •
edited
Loading

Related Task

Changes

  • Create ollama helper functions
  • Update endpoints to use ollama check for models on machine
  • Update pre-commit config check

Documentation

N/A

Local Testing

Success: Pull smolllm:360m

image

Checks if model present in ollama:
image

Direct call to see if model present:
image

Failed: With non_existent_yapper model

image

Inference with our TinyStories

image

@umama-rahman1 umama-rahman1 self-assigned this Feb 24, 2025
@umama-rahman1 umama-rahman1 marked this pull request as ready for review February 24, 2025 23:50
@umama-rahman1 umama-rahman1 changed the title add-ollama-helper-funcs Ollama Pull Model bug fix Feb 28, 2025
Daayim
Daayim approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@Daayim Daayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code. Ship it 🥇

K-rolls
K-rolls approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@K-rolls K-rolls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks solid, will test out with the frontend! Great work sir!

@umama-rahman1 umama-rahman1 merged commit 8b5acc0 into main Mar 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@K-rolls K-rolls K-rolls approved these changes

@ShairYousuf ShairYousuf ShairYousuf approved these changes

@cmatthews20 cmatthews20 cmatthews20 approved these changes

@Daayim Daayim Daayim approved these changes

Assignees

@umama-rahman1 umama-rahman1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@umama-rahman1 @K-rolls @ShairYousuf @cmatthews20 @Daayim