Skip to content

Conversation

@K-rolls
Copy link
Contributor

@K-rolls K-rolls commented Dec 18, 2024

Related Task

Changes

  • Subcommand Refactor
  • Model file management commands
  • inherited classes for quack and quack <> with pretty formatting
    image
    image

Local Testing

  • Tested all functions locally. I invite you to try it out yourself!

@K-rolls K-rolls added bug Something isn't working enhancement New feature or request labels Dec 18, 2024
@K-rolls K-rolls self-assigned this Dec 18, 2024
@K-rolls K-rolls changed the title Kr/subcommand refactor Subcommand Refactor + Model File Management Dec 18, 2024
Copy link

@Daayim Daayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work Keegan. Idk what they put you through over there... but this is the cleanest code I've seen.

Rating: 🦆🦆🦆🦆🦆

Copy link
Contributor

@umama-rahman1 umama-rahman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need clarification on one of the questions and I will run the cli locally before approving. Thanks

@K-rolls K-rolls requested a review from cmatthews20 January 11, 2025 18:05
Copy link
Contributor

@umama-rahman1 umama-rahman1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@K-rolls K-rolls merged commit 81d729a into main Jan 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants