Skip to content

G2-1780 Standard method for human readable list joins #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdgib merged 1 commit into from
Sep 15, 2025
Merged

G2-1780 Standard method for human readable list joins #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pj-create/src/main/java/com/g2forge/project/plan/create/CreateConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,6 @@ public Integer getSprint() {
public void validateFlags() {
final Set<String> referencedFlags = getIssues().stream().flatMap(issue -> issue.getFlags() == null ? Stream.empty() : issue.getFlags().stream()).collect(Collectors.toSet());
final Set<String> unknownFlags = HCollection.difference(referencedFlags, getSpecifiedFlags().keySet());
if (!unknownFlags.isEmpty()) throw new IllegalArgumentException("The following flags are refenced by issues, but are neither enabled nor disabled: " + unknownFlags.stream().collect(HCollector.joining(", ", ", & ")));
if (!unknownFlags.isEmpty()) throw new IllegalArgumentException("The following flags are refenced by issues, but are neither enabled nor disabled: " + unknownFlags.stream().collect(HCollector.joiningHuman()));
}
}
4 changes: 2 additions & 2 deletions pj-report/src/main/java/com/g2forge/project/report/Billing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ public IExit invoke(CommandInvocation<InputStream, PrintStream> invocation) thro
final List<Issue> relevantIssues = findRelevantIssues(client, request.getJql(), request.getUsers().keySet(), request.getStart(), request.getEnd());
issues = relevantIssues.stream().collect(Collectors.toMap(Issue::getKey, IFunction1.identity(), (i0, i1) -> i0));
}
log.info("Found: {}", issues.keySet().stream().collect(HCollector.joining(", ", ", & ")));
log.info("Found: {}", issues.keySet().stream().collect(HCollector.joiningHuman()));
final Map<Issue, Throwable> errors = new LinkedHashMap<>();
for (Issue issue : issues.values()) {
try {
Expand All @@ -295,7 +295,7 @@ public IExit invoke(CommandInvocation<InputStream, PrintStream> invocation) thro
final double hours = Math.round(byIssue.getTotal() * 100.0) / 100.0;
log.info("\t\t{} {}: {}h", issue, summary, hours);

final String assignees = byIssue.getUsers().stream().collect(HCollector.joining(", ", ", & "));
final String assignees = byIssue.getUsers().stream().collect(HCollector.joiningHuman());
final String link = server.getApi().createIssueLink(issue);
final StringBuilder ranges = new StringBuilder();
final List<Change> issueChanges = changes.get(issue);
Expand Down