Skip to content

Sustitute {callr} dependency#20

Merged
gaborcsardi merged 5 commits intogaborcsardi:mainfrom
lorenzwalthert:drop-callr
Aug 30, 2023
Merged

Sustitute {callr} dependency#20
gaborcsardi merged 5 commits intogaborcsardi:mainfrom
lorenzwalthert:drop-callr

Conversation

@gaborcsardi
Copy link
Copy Markdown
Owner

@gaborcsardi gaborcsardi commented Aug 30, 2023

@gaborcsardi gaborcsardi changed the title add standard workflow Sustitute {callr} dependency Aug 30, 2023
@gaborcsardi gaborcsardi merged commit b9b0c5a into gaborcsardi:main Aug 30, 2023
@gaborcsardi
Copy link
Copy Markdown
Owner Author

@lorenzwalthert I merged this, but it seems to break cyclocomp_package_dir(). Can you please take a look?

@lorenzwalthert
Copy link
Copy Markdown
Contributor

ufff... Long time... Hopefully before the weekend.

@gaborcsardi
Copy link
Copy Markdown
Owner Author

Actually, never mind, I'll have to undo this, because if you load the package into the current R session once, then you won't be able to update and reload it without restarting R.

@lorenzwalthert
Copy link
Copy Markdown
Contributor

Ok, so we can't get rid of the {callr} dependency?

@gaborcsardi
Copy link
Copy Markdown
Owner Author

Ok, so we can't get rid of the {callr} dependency?

Not without seriously crippling cyclocomp_package_dir().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants