Streamline main script.#12
Open
ben-e-whitney wants to merge 1 commit intogabru-md:masterfrom
ben-e-whitney:dev
Open
Streamline main script.#12ben-e-whitney wants to merge 1 commit intogabru-md:masterfrom ben-e-whitney:dev
ben-e-whitney wants to merge 1 commit intogabru-md:masterfrom
ben-e-whitney:dev
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
helpparameters for the arguments. You can use formatters if you want to put in the newlines manually.membersandnames, I think it's better to just let the exception raise. Then the user will at least see what the type of the exception is.os.path.join.range(len(replace[uid]))(AKArange(len(members))), we can directly iterate overzip(members, names).infile.seek(0), we can avoid reopening the file for every contributor.nameswill beNoneand theline.replacecall will fail. UsingDEFAULT_NAMEas a default avoids this.sys.exitcauses a nonzero exit code to be returned to the shell. See the documentation. We can instead just print the message and exit normally.Let me know if anything else is unclear.