Skip to content

Update napi.py script #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 80 commits into
base: master
Choose a base branch
from
Open

Update napi.py script #1

wants to merge 80 commits into from

Conversation

@emkor
Copy link

@emkor emkor commented Aug 12, 2018

  • ported script to Python 3
  • used with clause to make sure opened files are closed correctly
  • refactored a bit
  • implemented encoding from windows-1250 to unicode, so Linux and non-Polish Windows machines should be able to handle diacritics just fine
  • added some unit tests to confirm that unpacking and encoding is still working

emkor added 30 commits August 12, 2018 17:55
@emkor
ported script to python 3, corrected tab/spaces and formatting to mat…
791a1b5 
…ch PEP rules
@emkor
few more renames and method extractions to increase readability
7b73e21
@emkor
changed main loop strategy to best-effort, extracted exit codes as co…
cc0f2c4 
…nstants, few more renames, omitted checking if subtitle is already downloaded - what's the point if new subtitle is already in memory?
@emkor
added basic unit tests for generating hashes and for unpacking 7zippe…
583f3df 
…d content returned from NapiProjektApi
@emkor
added 7zipped subtitles for unit-testing purposes, implemented encodi…
c4000e2 
…ng of subtitles so they're proper unicodes, added test for the encoding
@emkor
wrapped opening files in with-clause for safety, moved exceptions to top
28c0356
@emkor
expanded readme, added gitignore
d100caf
@emkor
corrected markdown styling in readme, expanded readme
6cc3cff
@emkor
Merge branch 'master' of github.com:emkor/napi.py
88ca661
@emkor
corrected markdown styling in readme, expanded readme
490c593
@emkor
Merge branch 'master' of github.com:emkor/napi.py
b35d77b
@emkor
added exception info on failed read from movie file
b5e6b01
@emkor
removed accidentally copied script part
b87f949
@emkor
split script into separate files
32be276
@emkor
refactored implementation, implemented detecting source encoding, imp…
5bbda9f 
…lemented taking preferred target encoding instead of hard-coded utf-8
@emkor
chardet seems to be too erratic; reverted to hardcoded windows-1250 w…
02ec789 
…ith fallbacks
@emkor
reorganized package, added makefile and setup files, updated readme
3e54b93
@emkor
updated gitignore with build caches, changed venv path in makefile
07786f5
@emkor
bumped patch version, fixed tests, split method for decoding/encoding…
22320be 
… subs
@emkor
introduce logging instead of raw prints, update readme
5a27b7a
@emkor
add acceptance test, add base class to use as a lib, extend readme
99d9ca0
@emkor
add CI definition (travis)
f23c5a7
@emkor
add installation of 7z exec
799b61c
@emkor
add installation of 7z exec
a040d7f
@emkor
add scripts for publishing to pypi
f135c50
@emkor
reduce testing to just python 3.7 as travis would try to publish pack…
d127f9f 
…age in each environment, to be resolved later
@emkor
wrap if branch == master into bash script as it was failing on travis CI
1cd9b1b
@emkor
moving publishing code to script
41ebd24
@emkor
implement case with no such subtitles found
5bce86d
@emkor
implement feature of downloading subs for given hash, fix few bugs (m…
745d934 
…oving file between filesystems now should work)
emkor and others added 30 commits November 23, 2020 19:16
@emkor
bump minor versions
9f679d6
@emkor
rewrite the tests to use pytest approach
c35d33b
@emkor
support python 3.6 in travis CI
f28a557
@emkor
update patch revision as the changes were not in functionality
4396174
@lipowskm
Remove the usage of 7z (#2)
e879bfd 
* implement archive extraction using pylzma instead of using 7z in subprocess, update setup.py

* Update README.md

* Update setup.py
@emkor
implement workflow for github actions
ff03d43
@emkor
fix test failing due to double napi-py phrase in project path appea…
54ece62 
…ring in github actions CI environment
@emkor
change the CI badge to github-provided one
196e659
@emkor
remove travis CI - related configuration
f24738d
@emkor
bump patch revision
0742efb
@emkor
Update main.yml
faacc62 
correct conditional for checking for master branch
@emkor
install twine globally, remove it from dependencies
f393c39
@emkor
remove no-longer-required 7z-executable leftovers
86f896c
@emkor
fix bug with cross-device error while moving subs from /tmp to mounte…
2088e67 
…d network share on macOS
@emkor
correct grammar errors in readme, include python3-dev package as expl…
59f64fc 
…icit requirement for pylzma dependency, bump revision
@emkor
switch from setup.py to poetry tool for dependency management
e5f3ff3
@emkor
switch from check_call to run in acceptance tests
eb13757
@emkor
register CLI entrypoint in poetry
00498f6
@emkor
add black code reformatter as a part of CI job
7d59e8e
@emkor
bump patch revision to publish the pacakge on pypi
9ae8ddc
@emkor
switch back to publishing with twine
e2d959e
@emkor
increase logging in twine publish step
b1691fa
@emkor
add --skip-existing flag for twine to force uploading new release to …
2a25341 
…pypi
@emkor
publish new version with minor updated
f652eac
@emkor
re-format using black, bump dependencies, publish using tokens
86a1aa0
@steciuk
Fix encoding issues for utf-16 (#3)
3632fea 
* fix issues with utf-16 encoded subs

* add auto encoding detection using chardet

* add chardet as dependency and bump python to 3.7

* bump napi-py to 0.2.3

* add utf-16 test
@emkor
remove support for python 3.6, add support for 3.10
b9ca62b
@emkor
update dev dependencies
8ccf878
@emkor
update README.md, correct version number
f1b93ec
@emkor
Issue 4 test newer python (#5)
c2b3c06 
* test with python 3.11 and 3.12

* bump dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emkor @lipowskm @steciuk