Closed
Conversation
…_protrider_cv functions
…in_intensities function
…nd update related logic in the pipeline
… class and update related logic in the pipeline" This reverts commit 72717d9.
…cs, and handle artifacts
…rning rate scheduler in training functions
…ayer configurations
…_helper and stats modules
There was a problem hiding this comment.
Pull request overview
This PR adds model checkpointing and optional Weights & Biases logging, refactors residual-fitting/p-value computation to surface fitted parameters, and extends latent-dimension selection (incl. binary search) while updating CLI outputs and configuration.
Changes:
- Add checkpoint save/load support and optional wandb logging during training.
- Refactor stats fitting to return structured fit parameters; add grid-search results export.
- Update config/CLI/docs/tests and dependency metadata to support new options (wandb extra, new config fields).
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Adds wandb extra and its transitive deps; updates resolution markers. |
tests/test_pipeline_standard.py |
Adds assertions for a degrees-of-freedom output file. |
tests/test_pipeline_features.py |
Adds a test for non-common degrees of freedom using t-distribution. |
tests/test_pipeline_cv.py |
Removes cross-validation pipeline tests. |
tests/test_model_save_load.py |
Introduces checkpoint save/load and reuse tests. |
tests/test_config.py |
Removes CV-related fields from “all fields” config test. |
src/protrider/stats.py |
Introduces FitParameters dataclass; changes residual fitting / p-value API. |
src/protrider/pipeline.py |
Adds checkpoint IO + wandb integration; changes run() return signature; removes CV runner code. |
src/protrider/model/model.py |
Refines multi-layer module construction, PCA init for multi-layer, and early stopping/scheduler/wandb hooks in training. |
src/protrider/model/model_helper.py |
Adds GridSearchResult, returns it from find_latent_dim, and adds “bs” search method. |
src/protrider/model/__init__.py |
Re-exports GridSearchResult. |
src/protrider/datasets/protein_intensities.py |
Changes Parquet read settings (engine specified). |
src/protrider/config.py |
Adds checkpoint, wandb, early stopping, and common DF options; removes CV options; adds “bs” to q-method validation. |
src/protrider/cli.py |
Updates CLI to handle and persist fit parameters + grid search results. |
README.md |
Documents checkpoint_path and checkpoint behavior. |
pyproject.toml |
Adds wandb as an optional dependency group. |
config.yaml |
Adds checkpoint + wandb config knobs; adds common DF flag; removes CV section. |
.gitignore |
Ignores wandb outputs and checkpoint .pt files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
April 8, 2026 18:38
…usage, configuration, and output files
Contributor
Author
|
@copilot check updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important improvements and new features to the PROTRIDER codebase, focusing on model checkpointing, configuration flexibility, training stability, and logging. The most significant changes are summarized below.
Model Checkpointing and Configuration Enhancements:
checkpoint_pathconfig option, allowing users to save and reuse trained models, with documentation and config file updates (README.md,config.yaml,src/protrider/config.py). [1] [2] [3]patience,min_delta), common degrees of freedom for statistical testing, and more flexible latent dimension selection (find_q_methodnow accepts "bs"). [1] [2] [3]Training Stability and Logging:
File Handling and Output Improvements:
fastparquetengine and disabling index inference for consistency. [1] [2]Internal Refactoring and API Additions:
GridSearchResultdataclass for structured grid search output and saving results to CSV. [1] [2] [3]These changes collectively improve user experience, reproducibility, and model training robustness.