Open
Conversation
Signed-off-by: Aaron Jhaj <Aaron.Jhaj@ibm.com>
Signed-off-by: Aaron Jhaj <Aaron.Jhaj@ibm.com>
|
Build successful |
hobbit1983
approved these changes
Jan 18, 2023
* Upgrade versions of Galasa projects inttests uses, as out of date Signed-off-by: Jade Carino <jade.carino@ibm.com> * Bump CICSTS dependency to 0.25.0 Signed-off-by: Jade Carino <jade.carino@ibm.com> * Remove GitHubIssue annotation for RSE defect as is now fixed Signed-off-by: Jade Carino <jade.carino@ibm.com> * Annotate Docker inttests with GitHubIssue as there is a defect causing them to fail Signed-off-by: Jade Carino <jade.carino@ibm.com> --------- Signed-off-by: Jade Carino <jade.carino@ibm.com>
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
) * uplift dependency on galasa framework to 0.26.0 instead of 0,.25.0 Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com> * bump up versions to match the uber obr manually Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com> --------- Signed-off-by: Mike Cobbett <77053+techcobweb@users.noreply.github.com>
…resource available (#175) Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
…sts into compilation-test
Signed-off-by: Jade Carino <carino_jade@yahoo.co.uk>
|
Build successful |
jadecarino
requested changes
Mar 9, 2023
| outputFiles("simplatform-refactored", simplatformParent, false); | ||
|
|
||
|
|
||
| makeGradleProperties(); |
Member
There was a problem hiding this comment.
I think what this test is doing, is taking files that already exist in the Simplatform repository on Github and putting them in a new file structure for a test to use. As the gradle.properties file you are trying to create does not exist in Github, you will have to create it then allow it to be copied over like the other folders are. Similar to what is happening on line 53.
- Remove this method and call a method on like 54 called 'createParentGradleProperties(simplatformParent)' and implement this method doing a similar thing to what createParentSettings does, but for your gradle.properties file.
| private void makeGradleProperties() throws IOException{ | ||
| String gradleProperties = "gradle.properties"; | ||
| String obr = "sourceMaven=https://development.galasa.dev/main/maven-repo/obr/"; | ||
| Path gradlePropertiesFile = testRunDirectory.resolve("/.gradle/" + gradleProperties); |
Member
There was a problem hiding this comment.
Move this same logic into a different method called createParentGradleProperties as mentioned in my last comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.