Skip to content

Remove previous wheels before creating a new one.#182

Open
VJalili wants to merge 1 commit intogalaxyproject:masterfrom
VJalili:patch-1
Open

Remove previous wheels before creating a new one.#182
VJalili wants to merge 1 commit intogalaxyproject:masterfrom
VJalili:patch-1

Conversation

@VJalili
Copy link
Member

@VJalili VJalili commented May 15, 2019

Since there can be wheels belonging to different version of pulsar already existing in that folder, and since that can cause issues for building docker image as it uses *, hence it would be better to empty the folder of any previous wheels first.

Since there can be wheels belonging to different version of pulsar already existing in that folder, and since that can cause issues for building docker image as it uses `*`, hence it would be better to empty the folder of any previous wheels first.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 80.711% when pulling 6723f8d on VJalili:patch-1 into ddf2fde on galaxyproject:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 80.711% when pulling 6723f8d on VJalili:patch-1 into ddf2fde on galaxyproject:master.

@jmchilton
Copy link
Member

Encountered the same thing, but fixed it by including deleting the wheel in the make dist rule -> make clean.

@VJalili
Copy link
Member Author

VJalili commented May 16, 2019

@jmchilton both methods seem reasonable to me; we can implement whichever you prefer.

@bgruening
Copy link
Member

@VJalili make clean seems to me better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants