Open
Conversation
bernt-matthias
commented
Dec 2, 2025
| def _populate_manager_descriptions_from_ini(manager_descriptions, job_managers_config): | ||
| config = configparser.ConfigParser() | ||
| config.readfp(open(job_managers_config)) | ||
| config.read_file(open(job_managers_config)) |
Contributor
Author
There was a problem hiding this comment.
Note, ConfigParser.readfp has been replaced in python 3.2 https://docs.python.org/3/library/configparser.html#configparser.ConfigParser.read_file
bernt-matthias
force-pushed
the
managers-typing
branch
5 times, most recently
from
a3e8823 to
d578e78
Compare
should cover nearly everything except `pulsar/managers/util/cli`
bernt-matthias
force-pushed
the
managers-typing
branch
from
d578e78 to
10900fa
Compare
seems to fail at the moment galaxyproject#428
This reverts commit 0353ec2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should cover nearly everything except
pulsar/managers/util/cliI added a few
TODOin the code where feedback would be welcome.