Issue/improve export spacings #1
Conversation
When exporting a document to PDF, the headings spacings were too small, the break lines were not displayed. This commit fixes these issues by extending PDFExporter.
Move Blocknote styles to separate file.
| @@ -123,54 +25,29 @@ export const cssEditor = (readonly: boolean, isDeletedDoc: boolean) => css` | |||
| font-size: 1.25rem; | |||
| } | |||
| a { | |||
| color: var(--c--theme--colors--greyscale-600); | |||
| color: var(--c--theme--colors--greyscale-500); | |||
There was a problem hiding this comment.
The conditional expression ${readonly && padding-left: 10px;} injects the boolean value false into the CSS when readonly is false, producing invalid CSS. Use ${readonly ? 'padding-left: 10px;' : ''} instead.
| margin: 1rem 0; | ||
| width: 100%; | ||
| border: 1px solid #d3d2cf; | ||
| } | ||
| } |
There was a problem hiding this comment.
The media query uses the invalid syntax @media screen and (width <= 560px). It should be @media screen and (max-width: 560px).
| @@ -1,85 +1,11 @@ | |||
| import { css } from 'styled-components'; | |||
|
|
|||
There was a problem hiding this comment.
The conditional expression ${readonly && padding-left: 10px;} injects the boolean value false into the CSS when readonly is false, producing invalid CSS. Use ${readonly ? 'padding-left: 10px;' : ''} instead.
| @@ -1,85 +1,11 @@ | |||
| import { css } from 'styled-components'; | |||
|
|
|||
There was a problem hiding this comment.
The media query uses the invalid syntax @media screen and (width <= 560px). It should be @media screen and (max-width: 560px).
| @@ -1,85 +1,11 @@ | |||
| import { css } from 'styled-components'; | |||
|
|
|||
There was a problem hiding this comment.
The styled-components template literal is not closed properly; the closing backtick and curly brace are missing, which will cause a syntax error.
Purpose
Describe the purpose of this pull request.
Proposal
External contributions
Thank you for your contribution! 🎉
Please ensure the following items are checked before submitting your pull request:
git commit --signoff(DCO compliance)git commit -S)<gitmoji>(type) title description## [Unreleased]section (if noticeable change)