Skip to content

fix (global color scheme): fix jumping when dragging in color picker #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix (global color scheme): fix jumping when dragging in color picker #3645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73390de
fix jumping when dragging color picker
kaeizen Nov 25, 2025
a1cd0a8
add comment
kaeizen Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/plugins/global-settings/color-schemes/color-scheme-picker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,22 +236,25 @@ const ColorSchemePicker = props => {
}
}

const currentItem = cloneDeep( itemInEdit )
setItemInEdit( prevItem => {
// clone deep causes the color picker to jump when dragging, so we use a spread operator to create a new object
const currentItem = { ...prevItem }

if ( ! schemeHasValue( currentItem.colorScheme ) && changeDefaultName ) {
currentItem.name = currentItem?.key === 'scheme-default-1' ? 'Color Scheme 1' : 'Color Scheme 2'
}
if ( ! schemeHasValue( currentItem.colorScheme ) && changeDefaultName ) {
currentItem.name = currentItem?.key === 'scheme-default-1' ? 'Color Scheme 1' : 'Color Scheme 2'
}

currentItem.colorScheme[ property ][ currentState ] = color
currentItem.colorScheme[ property ][ currentState ] = color

if ( property === 'backgroundColor' && isGradient( color ) ) {
currentItem.colorScheme[ property ].desktopHover = ''
currentItem.colorScheme[ property ].desktopParentHover = ''
}
if ( property === 'backgroundColor' && isGradient( color ) ) {
currentItem.colorScheme[ property ].desktopHover = ''
currentItem.colorScheme[ property ].desktopParentHover = ''
}

setItemInEdit( currentItem )
updateColorSchemes( currentItem )

updateColorSchemes( currentItem )
return currentItem
} )
}

// For updating option to show the color scheme in color pickers
Expand Down
Loading