Move shared declarations into dedicated headers#810
Merged
HylianFreddy merged 1 commit intogamestabled:mainfrom Apr 10, 2026
Merged
Move shared declarations into dedicated headers#810HylianFreddy merged 1 commit intogamestabled:mainfrom
HylianFreddy merged 1 commit intogamestabled:mainfrom
Conversation
viccie211
approved these changes
Apr 9, 2026
|
|
||
| void EnOwl_DespawnInit(Actor* owl, GlobalContext* globalCtx); | ||
| void EnOwl_rUpdate(Actor* owl, GlobalContext* globalCtx); | ||
| void EnOwl_FastCutscene(GlobalContext* globalCtx); |
Contributor
There was a problem hiding this comment.
Was this unused? Otherwise, why remove it?
Collaborator
Author
There was a problem hiding this comment.
Yeah it was unused. I probably should've deleted it in the previous PR but I noticed it late 😅
PhlexPlexico
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the app's
.cppfiles include some headers from the base patch with ugly directives like#include "../code/src/entrance.h"that cause a bunch of useless declarations to be visible from the app files and create useless dependencies for Make (the stuff in the.dfiles).So, I moved all declarations that are used by both the patch and the app into separate headers under the
./shareddirectory, including them where required. I opted to name them all with as_prefix for clarity and to avoid include conflicts.I also placed the few shared definitions in a
shared_data.cfile which will be compiled for both subprojects.To avoid error squiggles in VS Code, developers will need to update their local
c_cpp_properties.json, adding something like this to the include path:"${workspaceFolder}/shared/**"