Fixes spoiler item checks for Rupeesanity items when Rupeesanity is off.#817
Closed
viccie211 wants to merge 3 commits intogamestabled:mainfrom
Closed
Fixes spoiler item checks for Rupeesanity items when Rupeesanity is off.#817viccie211 wants to merge 3 commits intogamestabled:mainfrom
viccie211 wants to merge 3 commits intogamestabled:mainfrom
Conversation
viccie211
commented
Apr 30, 2026
| splrDatLoc->ItemLocations[spoilerItemIndex].CollectType = COLLECTTYPE_REPEATABLE; | ||
| splrDatLoc->ItemLocations[spoilerItemIndex].RevealType = REVEALTYPE_ALWAYS; | ||
| } | ||
| else if(loc->IsCategory(Category::cFreestandingRupee) && Settings::ShuffleRupees.Value<bool>() == false){ |
Contributor
Author
There was a problem hiding this comment.
.Is(OFF) crashed the rando app. This does work
Collaborator
There was a problem hiding this comment.
You can use Option objects like boolean values. So you can check that the setting is disabled with:
!Settings::ShuffleRupees
viccie211
added a commit
to viccie211/OoT3D_Randomizer
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the spoiler checks of freestanding rupees to REVEALTYPE_ALWAYS if rupeesanity is off.
Clashes with #818
We should determine which one is preferrable