Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #33.
Remove
g.debugThe global
g.debugflag allow to enable/disable logging.In this PR, I removed this flag as the python logging module already provides mechanisms to control logging.
This change does not change the API nor the behaviour.
Remove logging config
In
meterbus/serial.pyon global levellogging.basicConfig(level=logging.INFO)was called.This might have unwanted sideeffects:
meterbus/serial.pyis loaded, logging might start.So I removed
logging.basicConfig(level=logging.INFO).The python logging suggests, that the application should configure logging and not a module at load time.