Release/3.4 #157
Open
Release/3.4 #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"read() buffer overflow on file /proc/stat" At the very first read : - the file is read in a buffer sized with 4096 bytes - if 4096 is not enough then the buffer i reallocated until the size is sufficient. - then the right size is memorized in buffersize Then all other are read with buffersize size with no possible re-allocation. This behaviour is an issue with files like /proc/stat which can grow with time leading to infinite "read() buffer overflow on file .." The purpose of the modification is to let the reallocation always possible
Modification done with ../lib/file.c "read() buffer overflow on file /proc/stat" At the very first read : - the file is read in a buffer sized with 4096 bytes - if 4096 is not enough then the buffer i reallocated until the size is sufficient. - then the right size is memorized in buffersize Then all other are read with buffersize size with no possible re-allocation. This behaviour is an issue with files like /proc/stat which can grow with time leading to infinite "read() buffer overflow on file .." The purpose of the modification is to let the reallocation always possible
Wrong RRD files rights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit commentaries of the two files