Correct UnitaryForm detection, introduce ClassicalForms
#139
+230
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnitaryForm: A root computation over a sometimes incorrect field caused the unitary form of certain matrix groups not to be detected reliably.UnitaryFormandBilinearForm: Unless I am mistaken, they were unnecessary; the randomization in MeatAxe is not relevant at this point (or am I wrong?). The retry loops only made the functions very unpleasant to use when groups were passed that do not preserve the corresponding form. With up to 1000 loop iterations, their use inClassicalForms(see below) was thus almost out of the question, because otherwiseClassicalFormswould have been unacceptably slow.ClassicalForms: This function will be used extensively for the implementation of C9-maximal subgroups.As noted in #86, the functions mentioned should perhaps be renamed in the future to avoid name collisions.