ci: add bun-windows-x64 to release matrix#181
Open
adamv99-eng wants to merge 1 commit intogarrytan:masterfrom
Open
ci: add bun-windows-x64 to release matrix#181adamv99-eng wants to merge 1 commit intogarrytan:masterfrom
adamv99-eng wants to merge 1 commit intogarrytan:masterfrom
Conversation
Produce a gbrain-windows-x64.exe on every tagged release so Windows users get an upgrade path. Currently `gbrain upgrade` on a binary install sends people to the Releases page, which has no Windows artifact. They either build locally or stay stuck on whatever version they first compiled. The matrix gains a per-target `ext` column so the same `--outfile` / upload-path pattern works everywhere: empty on macOS/Linux, `.exe` on Windows. `build:all` in package.json picks up the same third target so local parity matches CI. Depends on the compiled-binary asset-embedding fix (separate PR) for the produced .exe to actually run — without it PGLite startup crashes on every platform, not just Windows. The compile step itself succeeds regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
bun-windows-x64to the release build matrix so tagged releases publishgbrain-windows-x64.exealongside the Mac and Linux artifacts. Windows users currently have no upgrade path —gbrain upgradeon a binary install sends people to the Releases page, which has no Windows download. They either rebuild from source locally on every bump or stay stuck on whatever version they first compiled.Why this matters:
The npm name
gbrainis already taken (by an unrelated ML library,stormcolor/gbrain@1.3.1), sobun install -g gbrainisn't an option for Windows users either. Without a CI-published.exe, Windows has no supported install path at all. This PR closes that gap with one matrix entry.Changes
.github/workflows/release.yml— add Windows to the build matrix:extcolumn on the matrix so the shared--outfile/upload-artifact pathpattern works: empty on macOS/Linux,.exeon Windows.artifacts/gbrain-windows-x64/gbrain-windows-x64.exeto the release files list so the artifact lands on the Releases page.package.json— extendbuild:allwith the Windows target sobun run build:allmatches CI and local devs get parity.Dependency
Depends on the companion PR that fixes Bun's
--compileasset embedding for PGLite. Without that fix, the Windows.execompiles successfully (verified locally: 114 MB binary produced onwindows-latest-equivalent), but crashes at runtime on the first PGLite command withExtension bundle not found. Same crash happens on Mac and Linux today — it just hasn't been felt because the binary test loop is light. Merge that PR first, then this one.Test plan
bun build --compile --target=bun-windows-x64 --outfile bin/gbrain-windows-x64.exe src/cli.tssucceeds (887 modules bundled, ~114 MB output).os/target/artifact/extcombinations.🤖 Generated with Claude Code