fix: normalize extract slugs and dir parsing#184
Open
24601 wants to merge 1 commit intogarrytan:masterfrom
Open
fix: normalize extract slugs and dir parsing#18424601 wants to merge 1 commit intogarrytan:masterfrom
24601 wants to merge 1 commit intogarrytan:masterfrom
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slug + '.md'exists on diskgbrain extractin addition to--dir, sogbrain extract links /path/to/brainworks as users expectWhy this matters
There were two sharp edges in extraction:
Folder/INDEXwhile import stored slugified paths likefolder/index, so links/timeline for uppercased or otherwise-normalized filenames silently failed to materialize;gbrain extract links /path/to/brainsilently ignored the positional path and scanned.unless the caller knew to pass--dir.Together those make the graph look much flatter than the corpus actually is.
Test plan
bun test test/extract.test.tsbun test test/extract.test.ts test/slug-validation.test.ts test/sync.test.tsbun test