Skip to content

fix: remove outer transaction wrapper in sync to prevent PGlite deadlock #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jpumpkin1223 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove outer transaction wrapper in sync to prevent PGlite deadlock #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/commands/sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,12 @@ export async function performSync(engine: BrainEngine, opts: SyncOpts): Promise<
pagesAffected.push(newSlug);
}

// Process adds and modifies
const useTransaction = (filtered.added.length + filtered.modified.length) > 10;
// Process adds and modifies.
// NOTE: importFile manages its own transaction internally. Wrapping all
// importFile() calls in an outer engine.transaction() causes nested
// db.transaction() calls that deadlock PGlite's event loop indefinitely
// (reproducible with >10 files in a single sync). Each file import is
// individually atomic — no outer wrapper needed.
const processAddsModifies = async () => {
for (const path of [...filtered.added, ...filtered.modified]) {
const filePath = join(repoPath, path);
Expand All @@ -222,11 +226,7 @@ export async function performSync(engine: BrainEngine, opts: SyncOpts): Promise<
}
};

if (useTransaction) {
await engine.transaction(async () => { await processAddsModifies(); });
} else {
await processAddsModifies();
}
await processAddsModifies();

const elapsed = Date.now() - start;

Expand Down