Skip to content

test(e2e): isolate HOME in Setup Journey + Init Edge Cases blocks #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orendi84 wants to merge 1 commit into
base: master
Choose a base branch
from
+36 −4
Open

test(e2e): isolate HOME in Setup Journey + Init Edge Cases blocks #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions test/e2e/mechanical.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,13 +580,31 @@ describeE2E('E2E: Idempotency', () => {
// ─────────────────────────────────────────────────────────────────

describeE2E('E2E: Setup Journey', () => {
// Isolate HOME so `gbrain init --non-interactive --url ...` cannot clobber
// the developer's real ~/.gbrain/config.json when tests run against
// Supabase creds in CI, or against localhost in dev. See the pattern in
// test/e2e/migration-flow.test.ts for the canonical HOME-override setup.
let origHome: string | undefined;
let tempHome: string | undefined;

beforeAll(async () => {
origHome = process.env.HOME;
tempHome = mkdtempSync(join(tmpdir(), 'gbrain-e2e-setup-home-'));
process.env.HOME = tempHome;
await setupDB();
});
afterAll(teardownDB);
afterAll(async () => {
await teardownDB();
if (origHome === undefined) delete process.env.HOME;
else process.env.HOME = origHome;
try { if (tempHome) rmSync(tempHome, { recursive: true, force: true }); } catch { /* best-effort */ }
});

const cliCwd = join(import.meta.dir, '../..');
const cliEnv = () => ({ ...process.env, DATABASE_URL: process.env.DATABASE_URL! });
// Pass HOME explicitly so subprocesses see the temp HOME, not the caller's
// real HOME. Without this, ...process.env would have already been captured
// at module load before the beforeAll override took effect.
const cliEnv = () => ({ ...process.env, DATABASE_URL: process.env.DATABASE_URL!, HOME: process.env.HOME! });

test('gbrain init --non-interactive connects and initializes', () => {
const result = Bun.spawnSync({
Expand Down Expand Up @@ -650,10 +668,24 @@ describeE2E('E2E: Setup Journey', () => {
// ─────────────────────────────────────────────────────────────────

describeE2E('E2E: Init Edge Cases', () => {
afterAll(teardownDB);
// Same HOME-isolation rationale as the Setup Journey block above.
let origHome: string | undefined;
let tempHome: string | undefined;

beforeAll(() => {
origHome = process.env.HOME;
tempHome = mkdtempSync(join(tmpdir(), 'gbrain-e2e-init-edge-home-'));
process.env.HOME = tempHome;
});
afterAll(async () => {
await teardownDB();
if (origHome === undefined) delete process.env.HOME;
else process.env.HOME = origHome;
try { if (tempHome) rmSync(tempHome, { recursive: true, force: true }); } catch { /* best-effort */ }
});

test('init --non-interactive without URL fails gracefully', () => {
const env = { ...process.env };
const env = { ...process.env, HOME: process.env.HOME! };
delete env.DATABASE_URL;
delete env.GBRAIN_DATABASE_URL;
const result = Bun.spawnSync({
Expand Down
Loading