Security: Add URL validation to prevent SSRF attacks#37
Open
Jah-yee wants to merge 1 commit intogarrytan:mainfrom
Open
Security: Add URL validation to prevent SSRF attacks#37Jah-yee wants to merge 1 commit intogarrytan:mainfrom
Jah-yee wants to merge 1 commit intogarrytan:mainfrom
Conversation
- Added validateUrl() function to block file://, data:, and other dangerous protocols - Block localhost, 127.0.0.1, and .local domains - Applied validation to goto command and newTab method - Addresses issue garrytan#17: SSRF and local resource access via unrestricted URL handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds URL validation to prevent Server-Side Request Forgery (SSRF) and local file access attacks.
Changes
validateUrl()function to blockfile://,data://, and other dangerous protocols.localdomainsgotocommand andnewTabmethodAddresses
Security Impact
This prevents attackers from: