Open
Conversation
Previously, the 'stats' interface just used HWCPipe to interrogate performance counters from the device. HWCPipe is not widely supported, so this really only worked for Arm devices. This change allows multiple 'StatsProviders' to be used. Each provider can supply all, some, or none of the requested counters depending on its capabilities. Any counters not supplied by one provider will be requested of the next in the list until one is found, or we run out of providers. So, CPU counters can come from HWCPipe for example, whilst GPU counters come from Vulkan's extension which has been added as another provider. The StatsProvider defines an abstract interface that is implemented by the concrete providers. The parameters used for graphing the statistics have moved from the GUI classes into the StatsProvider also. This allows providers to modify the names, units and scaling of counters where these differ from the default values.
Simplifies code in device
Based on private feedback from Zandro, I've moved the construction of the stats object into the base VulkanSamples class which leaves individual samples to just request the samples they would like. The active_frame_index is no longer passed to update_stats() or the command_buffer_begun/ended() methods. It is fetched internally by the providers that require it.
size_t -> uint32_t
…d then used some lines below in the call to stats->request_stats
Owner
|
I actually think the WaitIdle sample is wrong, It should be overriding prepare_render_context() and then this wouldn't be required. I'll take a look. |
gary-sweet
pushed a commit
that referenced
this pull request
May 3, 2023
* logic_op_dynamic_state sample (#1) * Fix readme comment (#2) * Fix validation layers errors (KhronosGroup#3) * Fixes after review (KhronosGroup#4)
gary-sweet
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Implement patch control points sample (#2) Co-authored-by: Karina Murawko-Wiśniewska <karina.murawko-wisniewska@mobica.com> * Code format fix in patch_control_points.h According to Clang format checker updated code format * Added colors depending on the level of tesselation and rotated objects (KhronosGroup#3) * Updating the sample as commented in the review Image of sample updated Camera position updated Tessellation enabled after running sample Updated dynamically_tessellation and statically_tessellation names Asset updated * Code format fix According to Clang format checker updated code format * Updating the sample according to Andreas suggestions Readme update gui_settings.tess name update ubo_tess.tessellation name update shaders update * Updating the sample according to Andreas suggestions Updated typos Corrected errors with types --------- Co-authored-by: Karina Murawko-Wiśniewska <karina.murawko-wisniewska@mobica.com> Co-authored-by: Patryk-Jastrzebski-Mobica <127733949+Patryk-Jastrzebski-Mobica@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a fix for a crash in the Wait Idle sample: render_context is reset in WaitIdle::prepare and then used some lines below in the call to stats->request_stats, tested in Windows and Android.
Fixes (no issue submitted)
General Checklist:
Please ensure the following points are checked:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: