Open
Conversation
stefanbuettner
force-pushed
the
fix-cmake
branch
from
130e5a4 to
9c6fd8a
Compare
If libmpfr is not installed under the system paths, the project cannot be compiled. This way, libmpfr can be used from a non-standard location.
stefanbuettner
force-pushed
the
fix-cmake
branch
from
9c6fd8a to
3808b83
Compare
gaschler
requested changes
Dec 8, 2019
Owner
gaschler
left a comment
gaschler
left a comment
There was a problem hiding this comment.
Thanks for the contribution, but pull request needs to be entirely written by you.
| # MPFR_INCLUDE_DIR - the GMP include directory | ||
| # MPFR_LIBRARIES - Libraries needed to use GMP | ||
|
|
||
| # Copyright (c) 2006, Laurent Montel, <montel@kde.org> |
Owner
There was a problem hiding this comment.
Sorry, I can only accept pull requests written by you and if you accept the license in the top directory.
(Since this does not need more logic than standard cmake find scripts it should be easy to write.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to make a conan package out of the project but ran into some issues.
The first being, that
libmpfrandlibgmpcannot be used from a non-standard installation path which happens for example if they are also conan packages and reside in~/.conan/data.I tried to fix this by reenabling the
GMP_INCLUDE_DIRand adding aFindMPFR.cmakein the same manner as theFindGMP.cmake.Secondly, I could not install the project because the headers could not be found by the cmake installation directive. I fixed this by prepending
${CMAKE_CURRENT_SOURCE_DIR}.Now it works on my system 😉
Cheers,
Stefan