feat: ensure we can async-cancel all async types supported#9
Conversation
k13gomez
commented
Oct 23, 2025
- Implement AsyncCancellable on all supported async types
- Ensure we can attempt at best effort to interrupt all supported async types
- Replace WeakHashMap with Caffeine WeakKeys cache
Summary of ChangesHello @k13gomez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the asynchronous cancellation model within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
9f48d65 to
f36eb86
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces a robust and well-designed mechanism for cancelling various async types supported by the library. The key changes include implementing the AsyncCancellable protocol for all supported types, replacing the state management with a high-performance Caffeine cache, and refactoring the core macros to support cancellation. The test coverage has also been significantly improved. The changes are excellent overall. I have one critical comment regarding a dependency version and a medium-severity suggestion to improve consistency.
eb0d2a3 to
5b89eba
Compare
5b89eba to
fcd56c1
Compare