"Play next" for artists and albums #269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great App!
The "Play Next" function currently only works for individual tracks.
I was used to having this feature for whole albums and artist as well, so I implemented it in my fork.
I tested it on my personal device and with an emulator - it seems to work fine.
I think the "most interesting" part of the code (meaning the one most likely to have bugs), is the new method:
PlaybackService.enqueueAsNextTracks.The implementation borrows from both the
enqueueTrackAsNextand theenqueueTracksmethods.Songs are added after the current playing song, but if no song is currently playing, the newly enqueued album won't start playing (like it would when enqueuing tracks via
enqueueTrackAsNext).Are you interested in integrating this into odyssey?
If not, feel free to close this PR :)