feat(tcp): add with_nodelay() to TcpConnector#71
Merged
louisponet merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
TCP_NODELAY was unconditionally set to true on all sockets (outbound, reconnect, inbound accept). Add a configurable nodelay flag (default true) so callers can opt into Nagle coalescing for bulk throughput workloads where ~40ms latency is acceptable. Usage: TcpConnector::default().with_nodelay(false)
louisponet
force-pushed
the
lopo/configurable-nodelay
branch
from
9fdaf00 to
76c3641
Compare
ninaiiad
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCP_NODELAY was unconditionally set to
trueon all sockets (outbound connect, reconnect, inbound accept). This adds a configurablenodelayflag (defaulttrue, no behavior change) so callers can opt into Nagle coalescing for bulk throughput workloads.All three call sites (outbound
try_connect, and two inbound accept paths inpoll_with) respect the flag.