Conversation
|
I would like to see this commits squashed together and merged. It's not offensive to improve the strings this way, it is great. |
3a0c15f to
47acb76
Compare
|
@mafagafogigante @gaubert Commits quashed and rebased. Please merge :) |
|
This is better, so it doesn't pollute the history (more than it already is?). I can't help but add a "please merge" (you know your English, I didn't say that I had commit rights there OK?). Please merge this, it is a valuable improvement. |
|
Yes I know you don't have commit rights, I meant to tell you I did what you asked and ask @gaubert to merge! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first contribution to this excellent software.
Still a very small one, but I hope to be able to help with more important ones in the future.