Skip to content

protocol_connect: fix error metadata update #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tsubakiky merged 2 commits into from
May 17, 2025
Merged

protocol_connect: fix error metadata update #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c89c2
protocol_connect: fix error metadata update
tsubakiky May 13, 2025
8459992
protocol_connect: update error.metadata
tsubakiky May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/connect/protocol_connect/connect_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,8 @@ async def receive(self, message: Any, abort_event: asyncio.Event | None = None)
if error:
for key, value in self.response_headers.items():
error.metadata[key] = value
error.metadata.update(self.unmarshaler.trailers.copy())

error.metadata.update(self.unmarshaler.trailers.copy())
raise error

for key, value in self.unmarshaler.trailers.items():
Expand Down
1 change: 1 addition & 0 deletions src/connect/protocol_connect/error_json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ def error_from_json(obj: dict[str, Any], fallback: ConnectError) -> ConnectError

if type_name is None:
raise fallback

if value is None:
raise fallback

Expand Down
Loading