Conversation
407e1ed to
2f05f99
Compare
zchee
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the use of
AsyncClientSessionwithAsyncConnectionPoolacross the codebase to improve connection handling. The most significant changes involve updating imports, constructor arguments, and method parameters to reflect this transition. Below is a categorized summary of the key changes:Core Refactor: Transition to
AsyncConnectionPoolAsyncClientSessionwithAsyncConnectionPoolin various files, includinggenerator.go,client_runner.py, andservice_connect.py. [1] [2] [3]ConformanceServiceClientandElizaServiceClient) to accept apoolparameter instead ofsession. [1] [2] [3] [4]AsyncConnectionPoolfor managing connections. [1] [2]Updates to Client Logic
AsyncConnectionPoolin place ofAsyncClientSessionfor making requests, including in thehandle_messagefunction and client initialization. [1] [2] [3]ProtocolClientParams) to include apoolparameter instead ofsession. [1] [2]New Connection Pool Module
connection_pool.py, which provides theAsyncConnectionPoolfunctionality usinghttpcore.These changes ensure a more efficient and scalable approach to managing HTTP connections by leveraging connection pooling.