Skip to content

all: rename to connection pool#84

Merged
tsubakiky merged 1 commit intomainfrom
rename-connection-pool
May 14, 2025
Merged

all: rename to connection pool#84
tsubakiky merged 1 commit intomainfrom
rename-connection-pool

Conversation

@tsubakiky
Copy link
Copy Markdown
Collaborator

@tsubakiky tsubakiky commented May 14, 2025

This pull request replaces the use of AsyncClientSession with AsyncConnectionPool across the codebase to improve connection handling. The most significant changes involve updating imports, constructor arguments, and method parameters to reflect this transition. Below is a categorized summary of the key changes:

Core Refactor: Transition to AsyncConnectionPool

  • Replaced imports of AsyncClientSession with AsyncConnectionPool in various files, including generator.go, client_runner.py, and service_connect.py. [1] [2] [3]
  • Updated constructors for client classes (e.g., ConformanceServiceClient and ElizaServiceClient) to accept a pool parameter instead of session. [1] [2] [3] [4]
  • Modified function arguments and documentation to reflect the use of AsyncConnectionPool for managing connections. [1] [2]

Updates to Client Logic

  • Adjusted client logic to utilize AsyncConnectionPool in place of AsyncClientSession for making requests, including in the handle_message function and client initialization. [1] [2] [3]
  • Updated protocol-related classes (e.g., ProtocolClientParams) to include a pool parameter instead of session. [1] [2]

New Connection Pool Module

  • Introduced a new module, connection_pool.py, which provides the AsyncConnectionPool functionality using httpcore.

These changes ensure a more efficient and scalable approach to managing HTTP connections by leveraging connection pooling.

@tsubakiky tsubakiky requested a review from zchee May 14, 2025 04:51
@tsubakiky tsubakiky force-pushed the rename-connection-pool branch from 407e1ed to 2f05f99 Compare May 14, 2025 04:52
@tsubakiky tsubakiky merged commit 536d574 into main May 14, 2025
2 checks passed
@tsubakiky tsubakiky deleted the rename-connection-pool branch May 14, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants