Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to improve error handling, enhance timeout management, and refine the handling of peer and response metadata across multiple files in the
connectprotocol.Error Handling Improvements:
src/connect/protocol_grpc/error_trailer.py: Fixed a bug ingrpc_error_to_trailerby correcting the reference toerror.wire_errorinstead ofConnectError.wire_error.src/connect/protocol_grpc/grpc_client.py: Ensured thatserver_error.metadatauses a copy ofresponse_trailersto prevent unintended modifications.Timeout Management Enhancements:
src/connect/protocol_grpc/constants.py: IntroducedGRPC_TIMEOUT_MAX_VALUEandGRPC_TIMEOUT_MAX_DURATIONconstants for better timeout management. Updated the default gRPC user agent to include the Python version. [1] [2]src/connect/protocol_grpc/grpc_handler.py: Replaced hardcoded timeout validation withGRPC_TIMEOUT_MAX_DURATIONfor consistency.Peer and Metadata Handling:
src/connect/protocol_connect/connect_handler.pyandsrc/connect/protocol_grpc/grpc_handler.py: Updated peer initialization to setaddresstoNonewhenrequest.clientis unavailable, ensuring consistent behavior. [1] [2]src/connect/protocol_grpc/grpc_client.py: Implemented proper cleanup of tasks inasync def sendto avoid resource leaks.