Merged
Conversation
Member
|
@tsubakiky PR description? bug fix? or new feature? |
Member
|
@tsubakiky client conformance test failed |
Collaborator
Author
bug fix |
Member
|
@tsubakiky labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the handling of asynchronous streams in the
src/connect/content_stream.pyfile. Key changes include improvements to error handling, ensuring streams are properly closed, and allowing streams to be nullable. These updates enhance robustness and maintainability.Enhancements to error handling:
__aiter__methods of bothBoundAsyncStreamandAsyncDataStreamto raise anExceptionGroupwhen multiple errors occur during stream closure. This ensures better visibility of compound errors. [1] [2]Stream lifecycle management:
aclosemethods in bothBoundAsyncStreamandAsyncDataStreamto set_streamand_aclose_functoNoneafter closing, ensuring proper cleanup of resources. [1] [2]Nullable streams:
_streamattributes in bothBoundAsyncStreamandAsyncDataStreamto allowNonevalues, enabling safer handling of streams that may not be initialized. [1] [2]