feat(client): add unread indicator for completed sessions#101
Open
Master-cai wants to merge 1 commit intogbasin:masterfrom
Open
feat(client): add unread indicator for completed sessions#101Master-cai wants to merge 1 commit intogbasin:masterfrom
Master-cai wants to merge 1 commit intogbasin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an unread indicator for sessions that complete work while not currently selected.
Changes
unreadSessionIdsstate to session store.markSessionUnread(sessionId)markSessionRead(sessionId)working->waitingand the session is not selected.Setcorrectly).sessionStatetests.Why
When multiple agents run concurrently, it’s easy to miss that a background session has completed.
The unread indicator makes finished work discoverable without forcing a session switch.
Scope
SessionList, client store, styles, tests)Verification
bun run lintpassedbun run typecheckpassedbun run teststill has existing unrelated baseline failures in this repository (server-side test isolation/logging cleanup issues), not introducedby this PR.