fix: harden logging quality auditor correctness#83
Open
gbasin wants to merge 3 commits intofeat/dependency-risk-scannerfrom
Open
fix: harden logging quality auditor correctness#83gbasin wants to merge 3 commits intofeat/dependency-risk-scannerfrom
gbasin wants to merge 3 commits intofeat/dependency-risk-scannerfrom
Conversation
Nightshift-Task: logging-audit Nightshift-Ref: https://github.com/marcus/nightshift
Nightshift-Task: logging-audit Nightshift-Ref: https://github.com/marcus/nightshift
Nightshift-Task: logging-audit Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This iteration addresses reviewer feedback from PR #82 by fixing correctness gaps in the logging auditor so real violations are not missed, while preserving the backend logging quality bar established in prior iterations.
Scope
src/server/**)bun run audit:loggingWhat changed
src/server/loggingAudit.ts:logger['warn'](...)).warn/errorlogs now evaluate non-object payloads heuristically for real error signal.src/server/__tests__/loggingAudit.test.tsfor each corrected behavior.Validation
bun run lintbun run typecheckbun run testbun run audit:loggingResult:
logging_audit scanned_files=36 high=0 medium=0 low=0logging_audit_result cleanContext
Prior audit/remediation work remains included from earlier iterations (PR #81/#82): server error-path logging coverage, audit command/docs, and structured logging contract.