Skip to content

Conversation

iliekturtles
Copy link

In addition to '#', also consider ';', '!', '$',
'%', '^', '&', '|', and ':' as comment characers.

This change does not read core.commentChar or core.commentString from a user's git config but instead uses the fixed list of characters above as a "short-term" fix for #45/#75.


This is a rough start to support additional comment characters. All tests pass, but I expect there is additional work to clean things up.

  • @ is removed from the list of characters used by Neovim.
  • After actual testing with Neovim, it does read the user's git config. The static list above may only be for scissor detection.
  • This change has effects on some of the tests that used to look for non-conventional commits starting with !, ...
  • I haven't looked into what needs to change to ensure new translations inside the generated_comment_separator block are correct.

In addition to '#', also consider ';', '!', '$',
'%', '^', '&', '|', and ':' as comment characers.

This change *does not* read `core.commentChar` or `core.commentString`
from a user's git config but instead uses the fixed list of characters
above as a "short-term" fix for gbprod#45/gbprod#75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant