Update main.go #3
Conversation
Added prime number function
|
Thank you for providing the summary of changes. I will now review the Chat with
|
![coderabbit-nyctonid[bot]](https://avatars.githubusercontent.com/u/46122307?s=60&v=4){kind=small}
| func printPrimeNumbers(num1, num2 int){ | ||
| if num1<2 || num2<2{ | ||
| fmt.Println("Numbers must be greater than 2 for this to work.") | ||
| return | ||
| } | ||
| for num1 <= num2 { | ||
| isPrime := true | ||
| for i:=2; i<=int(math.Sqrt(float64(num1))); i++{ | ||
| if num1 % i == 0{ | ||
| isPrime = false | ||
| break | ||
| } | ||
| } | ||
| if isPrime { | ||
| fmt.Printf("Found Prime number: %d ", num1) | ||
| } | ||
| num1++ | ||
| } | ||
| fmt.Println() | ||
| } |
There was a problem hiding this comment.
The printPrimeNumbers function currently prints the prime numbers directly to the console. It would be more useful if it returned a slice of prime numbers instead. This way, the function can be used in different contexts, such as returning the prime numbers in an HTTP response.
| func printPrimeNumbers(num1, num2 int){ | |
| if num1<2 || num2<2{ | |
| fmt.Println("Numbers must be greater than 2 for this to work.") | |
| return | |
| } | |
| for num1 <= num2 { | |
| isPrime := true | |
| for i:=2; i<=int(math.Sqrt(float64(num1))); i++{ | |
| if num1 % i == 0{ | |
| isPrime = false | |
| break | |
| } | |
| } | |
| if isPrime { | |
| fmt.Printf("Found Prime number: %d ", num1) | |
| } | |
| num1++ | |
| } | |
| fmt.Println() | |
| } | |
| func printPrimeNumbers(num1, num2 int) []int { | |
| primes := []int{} | |
| if num1 < 2 || num2 < 2 { | |
| return primes | |
| } | |
| for num1 <= num2 { | |
| isPrime := true | |
| for i := 2; i <= int(math.Sqrt(float64(num1))); i++ { | |
| if num1 % i == 0 { | |
| isPrime = false | |
| break | |
| } | |
| } | |
| if isPrime { | |
| primes = append(primes, num1) | |
| } | |
| num1++ | |
| } | |
| return primes | |
| } |
Added prime number function
Summary by CodeRabbit
Thank you for providing the summary of changes. I will now review the
printPrimeNumbersfunction inbundle-server/main.go. Please provide the code snippet for this function so that I can analyze it and suggest improvements if necessary.