Update main.go #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added prime number function
|
Here is the summary of changes:
Chat with
|
![coderabbit-nyctonid[bot]](https://avatars.githubusercontent.com/u/46122307?s=60&v=4){kind=small}
Comment on lines
+28
to
+47
| func printPrimeNumbers(num1, num2 int){ | ||
| if num1<2 || num2<2{ | ||
| fmt.Println("Numbers must be greater than 2 for this to work.") | ||
| return | ||
| } | ||
| for num1 <= num2 { | ||
| isPrime := true | ||
| for i:=2; i<=int(math.Sqrt(float64(num1))); i++{ | ||
| if num1 % i == 0{ | ||
| isPrime = false | ||
| break | ||
| } | ||
| } | ||
| if isPrime { | ||
| fmt.Printf("Found Prime number: %d ", num1) | ||
| } | ||
| num1++ | ||
| } | ||
| fmt.Println() | ||
| } |
There was a problem hiding this comment.
The printPrimeNumbers function currently prints the prime numbers to the console. It would be more useful to return a slice of prime numbers instead, so that the caller can decide how to use the results.
Suggested change
| func printPrimeNumbers(num1, num2 int){ | |
| if num1<2 || num2<2{ | |
| fmt.Println("Numbers must be greater than 2 for this to work.") | |
| return | |
| } | |
| for num1 <= num2 { | |
| isPrime := true | |
| for i:=2; i<=int(math.Sqrt(float64(num1))); i++{ | |
| if num1 % i == 0{ | |
| isPrime = false | |
| break | |
| } | |
| } | |
| if isPrime { | |
| fmt.Printf("Found Prime number: %d ", num1) | |
| } | |
| num1++ | |
| } | |
| fmt.Println() | |
| } | |
| func printPrimeNumbers(num1, num2 int) []int { | |
| if num1 < 2 || num2 < 2 { | |
| fmt.Println("Numbers must be greater than 2 for this to work.") | |
| return nil | |
| } | |
| primes := []int{} | |
| for num1 <= num2 { | |
| isPrime := true | |
| for i := 2; i <= int(math.Sqrt(float64(num1))); i++ { | |
| if num1 % i == 0 { | |
| isPrime = false | |
| break | |
| } | |
| } | |
| if isPrime { | |
| primes = append(primes, num1) | |
| } | |
| num1++ | |
| } | |
| return primes | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added prime number function
Summary by CodeRabbit