Rename code_25250 -> controller and decompile functions #12
Conversation
queueRAM
commented
Jan 17, 2026
queueRAM
commented
- Rename code_25250 -> controller
- Add uv_controller.h interface
- Decompile uvControllerInit (func_802242A0)
- Decompile func_80224548
- Decompile uvControllerButtonCheck (func_802245B0)
- Decompile uvControllerGetButton (func_802245E8)
- Decompile uvControllerCheckInserted (func_8022445C)
- Decompile uvControllerGetStick (func_8022458C)
- Decompile uvControllerButtonPress (func_80224604)
- Decompile uvControllerButtonRelease (func_80224650)
- Decompile fakematch uvIOUpdate
- Rename code_25250 -> controller - Add uv_controller.h interface - Decompile uvControllerInit (func_802242A0) - Decompile func_80224548 - Decompile uvControllerButtonCheck (func_802245B0) - Decompile uvControllerGetButton (func_802245E8) - Decompile uvControllerCheckInserted (func_8022445C) - Decompile uvControllerGetStick (func_8022458C) - Decompile uvControllerButtonPress (func_80224604) - Decompile uvControllerButtonRelease (func_80224650) - Decompile fakematch uvIOUpdate
| u32 contPattern; | ||
| s32 mask; | ||
|
|
||
| // 6 controllers and 3 axes on the stick |
There was a problem hiding this comment.
6 controllers i think was artifact of HW1 and early SDKs supporting that quantity. 3 axes on the stick is curious
| extern s32 gControllerPattern; | ||
| extern ControllerInfo gControllerInfo[6]; | ||
|
|
||
| void uvControllerInit(void) { |
There was a problem hiding this comment.
These function names get a bit long. Let me know if you prefer uvContInit or some other naming scheme
There was a problem hiding this comment.
yeah we already shorten most other subsystem names so this would be appropriate
it would also be consistent with the os equivalents, e.g. osContStartQuery
|
|
||
| u8 func_8022EA80(void) { | ||
| u8 uvContMesgInit(void) { | ||
| OSMesg mesgBuf[2]; |
There was a problem hiding this comment.
Based on passing 2 to osCreateMesgQueue this needed to be an array. Reordered the stack to continue matching
| return 0; | ||
| } | ||
|
|
||
| #pragma GLOBAL_ASM("asm/nonmatchings/kernel/controller/D_8024DF40.s") |
There was a problem hiding this comment.
I think some of the functions in graphics.c belong in controller.c which may correct this data issue. I'm still experimenting.
Edit: doesn't look like anything should be moved from graphics to controller. Maybe a different file in between. Saving this for another PR
There was a problem hiding this comment.
yeah definitely don't assume the current splits are perfect. if the alignment and padding works out, then feel free to make more granular splits if it makes better logical groupings
2 participants
