Split end of graphics.c to match rodata #13
Merged
+133
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
queueRAM
commented
Jan 17, 2026
queueRAM
commented
- Split graphics starting at 80223E80 to new file code_24E30
- Clean up functions to use now better known structs
- Split graphics starting at 80223E80 to new file code_24E30 - Clean up functions to use now better known structs
queueRAM
force-pushed
the
fixup_rodata_please
branch
from
62bc465 to
06e0b7b
Compare
queueRAM
commented
Jan 17, 2026
| u32 tag; | ||
| u32 unk8; | ||
| u32 offset; | ||
| } Unk802B5300; |
Contributor
Author
There was a problem hiding this comment.
I renamed this since I wasn't certain if it was still related to the orig UnkStruct_gfx_16b
| - [0x4E830, .rodata, kernel/code_1AF80] | ||
| - [0x4EB30, .rodata, kernel/code_200B0] | ||
| - [0x4EBD0, .rodata, kernel/graphics] | ||
| - [0x4EEF0, .rodata, kernel/code_24E30] |
Contributor
Author
There was a problem hiding this comment.
This fixes the .rodata issue, but is my first time splitting. Let me know if there is anything else to improve upon
| return D_802B5300[arg0].unk8; | ||
| } | ||
|
|
||
| s32 func_80223F68(s32 arg0) { |
Contributor
Author
There was a problem hiding this comment.
Difficult to tell in this diff since I both moved the functions and updated them, but I changed this and the other functions from the following method which always used .address and different base pointers. Just wanted to call it out that there are source changes here.
s32 func_80223F68(s32 arg0) {
return D_802B5304[arg0].address;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.