Skip to content

Fix: Bounds checking for repeat count in handleWinKey #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dejlek wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Bounds checking for repeat count in handleWinKey #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52de091
Fix: Bounds checking for repeat count in `handleWinKey`
dejlek Feb 12, 2026
1fb7fbc
Added DDoc style comment to the handleWinKey()
dejlek Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions source/dcell/parser.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
module dcell.parser;

import core.time;
import std.algorithm : max;
import std.algorithm : max, min;
import std.ascii;
import std.base64;
import std.conv : to;
Expand Down Expand Up @@ -1001,6 +1001,21 @@ private:
evs ~= newMouseEvent(x, y, button, mod);
}

/***
* Handles Win32 input mode key sequences (CSI ... _).
*
* Parses a Win32 console input key event encoded as a CSI sequence with
* six semicolon-separated parameters, and translates it into one or more
* key events appended to `evs`.
*
* Params:
* p0 = wVirtualKeyCode (default 0)
* p1 = wVirtualScanCode (default 0)
* p2 = UnicodeChar as a decimal value (default 0)
* p3 = bKeyDown — 1 for key-down, 0 for key-up (default 0)
* p4 = dwControlKeyState — modifier flags (default 0)
* p5 = wRepeatCount — clamped to [1, 1024] to prevent CPU hang (default 1)
*/
void handleWinKey(int p0, int p1, int p2, int p3, int p4, int p5) @safe
{
// win32-input-mode
Expand Down Expand Up @@ -1046,7 +1061,7 @@ private:
auto key = Key.graph;
auto chr = p2;
auto mod = Modifiers.none;
auto rpt = max(1, p5);
auto rpt = min(max(1, p5), 1024);

if (p0 in winKeys)
{
Expand Down