Skip to content

Fix/remove smtp secrets env example#79

Merged
krishnapaljadeja merged 2 commits intogdg-charusat:mainfrom
Atibali:fix/remove-smtp-secrets-env-example
Mar 1, 2026
Merged

Fix/remove smtp secrets env example#79
krishnapaljadeja merged 2 commits intogdg-charusat:mainfrom
Atibali:fix/remove-smtp-secrets-env-example

Conversation

@Atibali
Copy link
Copy Markdown
Contributor

@Atibali Atibali commented Feb 27, 2026

Team Number : Team 137

Description

This PR fixes a Level-2 security issue by removing sensitive SMTP credentials from .env.example.
The environment template now contains placeholder values only, preventing accidental credential exposure in version control.

Related Issue

Closes #75

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Style/UI improvement

Changes Made

  • Replaced hardcoded SMTP_USER value in .env.example with a safe placeholder.
  • Replaced hardcoded SMTP_PASS value in .env.example with a safe placeholder.
  • Verified no real SMTP credentials remain in tracked template configuration.

Screenshots (if applicable)

Before:
N/A (backend configuration/security fix)

After:
N/A (backend configuration/security fix)

Testing

  • Tested on Desktop (Chrome/Firefox/Safari)
  • Tested on Mobile (iOS/Android)
  • Tested responsive design (different screen sizes)
  • No console errors or warnings
  • Code builds successfully (npm run build)

Additional verification performed:

  • Confirmed .env is not tracked in git.
  • Confirmed .env.example contains placeholders for SMTP_USER and SMTP_PASS.

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • My changes generate no new warnings
  • I have tested my changes thoroughly
  • All TypeScript types are properly defined
  • Tailwind CSS classes are used appropriately (no inline styles)
  • Component is responsive across different screen sizes
  • I have read and followed the CONTRIBUTING.md guidelines

Additional Notes

  • No functional API logic was changed; this is a security hardening change in configuration templates only.
  • Maintainers should rotate/revoke previously exposed SMTP credentials immediately.

@krishnapaljadeja krishnapaljadeja self-requested a review February 27, 2026 16:52
@krishnapaljadeja krishnapaljadeja added the needs-review Valid issue-linked PR awaiting review label Feb 27, 2026
@krishnapaljadeja
Copy link
Copy Markdown
Contributor

✅ PR Validation Passed

Hey @Atibali! Your PR looks good. Here is what we found:

Field Value
Team Number Team 137
Linked Issue Closes #75

A maintainer will review your PR within 24–48 hours. Stay responsive to feedback!

GDG CHARUSAT Open Source Contri Sprintathon

@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Feb 28, 2026
@krishnapaljadeja
Copy link
Copy Markdown
Contributor

@Atibali Please revert all non-related changes and keep this PR strictly limited to .env.example.
If the controller changes are necessary, feel free to open a separate PR with a clear description and rationale.

This helps keep reviews focused, avoids unintended side effects, and maintains a clean project history.

Thanks!

@Atibali Atibali force-pushed the fix/remove-smtp-secrets-env-example branch from 1cc262f to aa9899f Compare March 1, 2026 00:13
@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Mar 1, 2026
@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Mar 1, 2026
@krishnapaljadeja krishnapaljadeja merged commit 22fca83 into gdg-charusat:main Mar 1, 2026
1 check passed
@krishnapaljadeja
Copy link
Copy Markdown
Contributor

🎉 PR Merged — Points Awarded!

Congratulations @Atibali! Your contribution has been merged.

Field Value
Repo Code_duel_backend
Team Team 137
Contributor @Atibali
Level Level 1 — Beginner
Points Awarded 5 pts
Source Linked Issue #75

The central leaderboard has been updated. Keep contributing!

GDG CHARUSAT Open Source Contri Sprintathon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Valid issue-linked PR awaiting review pr-noted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Level-2 Security Bug] Sensitive SMTP Credentials Committed to Repository (.env.example)

3 participants