Title: Implement Infinite Scroll for Challenge List T113#127
Closed
7JankiPanchal wants to merge 3 commits intogdg-charusat:mainfrom
Closed
Title: Implement Infinite Scroll for Challenge List T113#1277JankiPanchal wants to merge 3 commits intogdg-charusat:mainfrom
7JankiPanchal wants to merge 3 commits intogdg-charusat:mainfrom
Conversation
Contributor
✅ PR Validation PassedHey @7JankiPanchal! Your PR looks good. Here is what we found:
A maintainer will review your PR within 24–48 hours. Stay responsive to feedback!
|
Contributor
|
hey @7JankiPanchal your branch is not up to date with the latest main. |
Contributor
|
hey @7JankiPanchal if you are working on this then please commit within the next hour |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Team Number : Team 113
linked issue
closes #120
Description
This PR performs a comprehensive type-safety refactor and standardization of the core frontend architecture.
Key improvements:
Resolves 100+ ESLint errors and warnings, focusing on unsafe any usages and missing hook dependencies.
Introduces robust interfaces for Users and LeetCode profiles for safer property access.
Improves maintainability and overall code reliability.
Additionally, this PR implements enhanced date validation logic for forms:
Start Date: Can only be today or a future date.
End Date:
Disabled until a Start Date is selected.
Must be at least one day after the Start Date.
Automatically clears if it becomes invalid due to changes in Start Date.
Related Issue
N/A
Type of Change
New feature (non-breaking addition)
Style / UI improvement
Changes Made
Added min date validation using date-fns.
Implemented Start Date / End Date dependencies with auto-validation.
Replaced unsafe any types with proper TypeScript interfaces.
Ensured all hook dependencies are correctly defined.
Screenshots / Walkthrough
Visual documentation available in the walkthrough.
Testing
Desktop (Chrome) tested
Verified Start Date / End Date logic
No console errors or warnings
Code builds successfully
Checklist
Code follows project style guidelines
Self-reviewed code
Added comments where necessary
No new warnings generated
TypeScript types properly defined
Tailwind CSS classes used appropriately
Component responsive across screen sizes
CONTRIBUTING.md guidelines followed
Additional Notes
Uses date-fns for date manipulation, already part of project dependencies.