Skip to content

fix/email-verification-implementation-T126#128

Closed
Mantra-17 wants to merge 1 commit intogdg-charusat:mainfrom
mitesh006:main
Closed

fix/email-verification-implementation-T126#128
Mantra-17 wants to merge 1 commit intogdg-charusat:mainfrom
mitesh006:main

Conversation

@Mantra-17
Copy link
Copy Markdown

@Mantra-17 Mantra-17 commented Feb 28, 2026

Team Number : Team 126

Description

This PR implements a comprehensive email verification system that prevents users from auto-logging in after registration. The implementation ensures users must verify their email before accessing protected routes, resolving security concerns and improving user authentication flow.

Related Issue

Closes #109

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Style/UI improvement

Changes Made

  • AuthContext: Removed auto-login logic from registration function

-Registration Flow: Redirects to email verification pending page instead of dashboard

-Login Enhancement: Added 403 error handling for unverified email accounts

-New Page: Created VerifyEmailPending.tsx with clear user instructions

-Route Configuration: Added /verify-email-pending route to App.tsx

-Backend Integration: Proper handling of email verification tokens and status

Testing

  • Tested on Desktop (Chrome)
  • Tested logic for Start Date and End Date dependencies
  • No console errors or warnings
  • Code builds successfully

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • My changes generate no new warnings
  • I have tested my changes thoroughly
  • All TypeScript types are properly defined
  • Tailwind CSS classes are used appropriately
  • Component is responsive across different screen sizes
  • I have read and followed the CONTRIBUTING.md guidelines

Additional Notes

This implementation follows security best practices by requiring email verification before granting access. The user flow is designed to be clear and intuitive, with proper error messaging and visual feedback throughout the verification process.

@krishnapaljadeja krishnapaljadeja self-requested a review February 28, 2026 14:30
@krishnapaljadeja krishnapaljadeja added the needs-admin-review General improvement PR - admin must assign level label Feb 28, 2026
@krishnapaljadeja
Copy link
Copy Markdown
Contributor

🔍 General Improvement PR — Pending Admin Review

Hey @Mantra-17! Your PR has been received as a General Improvement PR (no linked issue).

Field Value
Team Number Team 126
Linked Issue None

What happens next:

  1. An admin will review your changes
  2. If approved, an admin will add a level-1 or level-2 label based on complexity
  3. Points are calculated automatically when the PR is merged

⚠️ Trivial or low-quality PRs may be closed without merging.
Admin review may take longer than standard PRs.

GDG CHARUSAT Open Source Contri Sprintathon

@krishnapaljadeja
Copy link
Copy Markdown
Contributor

krishnapaljadeja commented Feb 28, 2026

@Mantra-17 pls fix the description format, add Closes# number also fix the conflicts

@krishnapaljadeja krishnapaljadeja added 8-pm needs-review Valid issue-linked PR awaiting review and removed needs-admin-review General improvement PR - admin must assign level labels Feb 28, 2026
@krishnapaljadeja
Copy link
Copy Markdown
Contributor

✅ PR Validation Passed

Hey @Mantra-17! Your PR looks good. Here is what we found:

Field Value
Team Number Team 126
Linked Issue Closes #109

A maintainer will review your PR within 24–48 hours. Stay responsive to feedback!

GDG CHARUSAT Open Source Contri Sprintathon

@Mantra-17
Copy link
Copy Markdown
Author

Hey I have updated the description pls check it and let me know

@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Feb 28, 2026

hey @Mantra-17 please resolve the conflicts. your pr is too farther away from main. take a pull from main before committing.

@Mantra-17
Copy link
Copy Markdown
Author

working on it give me some time

@Mantra-17
Copy link
Copy Markdown
Author

Resolved the issues

@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Feb 28, 2026

hey @Mantra-17 your work is still not up to date with main. take a pull from main then merge with your work.

@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Mar 1, 2026

hey @Mantra-17 if we dont get any commit in the next hour, we will close this pr.

@aaleya5 aaleya5 closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8-pm needs-review Valid issue-linked PR awaiting review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Registration Flow to Support Email Verification

3 participants