Skip to content

Introduced consistent Loading, Error and Empty states across Dashboard, Leaderboard and Challenge views #77

Closed
Yashvi29-power wants to merge 5 commits intogdg-charusat:mainfrom
Yashvi29-power:feat/consistent-ui-states
Closed

Introduced consistent Loading, Error and Empty states across Dashboard, Leaderboard and Challenge views #77
Yashvi29-power wants to merge 5 commits intogdg-charusat:mainfrom
Yashvi29-power:feat/consistent-ui-states

Conversation

@Yashvi29-power
Copy link
Copy Markdown
Contributor

@Yashvi29-power Yashvi29-power commented Feb 25, 2026

Team Number : Team 125

Description
This PR improves UI feedback and interaction clarity across the Code Duel frontend by introducing consistent Loading, Error, and Empty states. Skeleton components are used during async operations, while EmptyState provides clear messaging when data is unavailable or fails to load. The goal is to enhance perceived performance and maintain visual consistency without modifying existing business logic.

Related Issue
Closes #65

Type of Change
☐ Bug fix
☐ New feature
☐ Breaking change
☐ Documentation update
☐ Code refactoring
☐ Performance improvement
☑ Style/UI improvement

Changes Made

  • Added Skeleton loading states for Dashboard, Leaderboard, and Challenge views
  • Introduced minimal error UI using existing EmptyState component
  • Standardized empty data feedback across major pages
  • Maintained existing design system and Tailwind styling
  • Ensured no changes to API logic, routing, or authentication flow

Testing
☑ Tested on Desktop
☑ No console errors during navigation
☑ Application builds successfully

Additional Notes
This PR focuses strictly on UI/UX enhancements. Existing architecture, API integrations, and data models remain unchanged to ensure safe integration with the current codebase.

SCREENSHOTS ARE NOT ATTACHED AS WAS NOT ABLE TO GET ACCESS TO THE DASHBOARD OF THE WEBSITE AND THERE WERE SOME BACKEND ISSUES. GOOD AT FRONTEND, SO FOCUSED ON THAT

@krishnapaljadeja krishnapaljadeja self-requested a review February 25, 2026 06:30
@krishnapaljadeja krishnapaljadeja added the needs-review Valid issue-linked PR awaiting review label Feb 25, 2026
@krishnapaljadeja
Copy link
Copy Markdown
Contributor

✅ PR Validation Passed

Hey @Yashvi29-power! Your PR looks good. Here is what we found:

Field Value
Team Number Team 125
Linked Issue Closes #65

A maintainer will review your PR within 24–48 hours. Stay responsive to feedback!

GDG CHARUSAT Open Source Contri Sprintathon

@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Feb 25, 2026
@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Feb 26, 2026

the skeleton components need to be merged into the pages.
also, take a pull from main and then make changes so as to resolve merge conflicts.
@Yashvi29-power

@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Feb 27, 2026
@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Feb 27, 2026

please resolve conflicts

@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Feb 27, 2026
@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Feb 27, 2026
@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Feb 28, 2026

@Yashvi29-power please atleast run the project before committing. there are multiple errors that are not there previously in my main branch. the project doesnt even run if i merge your pull request.
run it when you resolve the merge conflicts so that if something goes haywire, you can test it out.

@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Feb 28, 2026
@Yashvi29-power
Copy link
Copy Markdown
Contributor Author

working on it

@krishnapaljadeja krishnapaljadeja added needs-review Valid issue-linked PR awaiting review and removed needs-review Valid issue-linked PR awaiting review labels Feb 28, 2026
@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Feb 28, 2026

hey @Yashvi29-power the errors are syntactical errors that arose when you resolved your merge conflicts.
run this project and resolve them before commit.

@aaleya5
Copy link
Copy Markdown
Contributor

aaleya5 commented Mar 1, 2026

@Yashvi29-power are you going to work on this? confirm within an hour.

@Yashvi29-power
Copy link
Copy Markdown
Contributor Author

I was working on it but not able to resolve it

@aaleya5 aaleya5 closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Valid issue-linked PR awaiting review pr-noted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Consistent Loading, Error, and Empty States Across Dashboard and Challenge Views (Team 125)

3 participants