Gdr 3290

[bczech]

Description

What changed?

Force to use character for G# and clid
Related JIRA issue: GDR-3290

Why was it changed?

To fix issue with conversion some ids into numeric

Checklist for sustainable code base

• I added tests for any code changed/added
• I added documentation for any code changed/added
• I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

• Package version bumped
• Changelog updated

Screenshots (optional)

[gemini-code-assist]

Summary of Changes

Hello @bczech, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where numeric identifiers for cell lines and drugs were causing conversion problems within the package's annotation functions. By explicitly casting these identifiers to character type at various stages of the annotation process, the changes ensure robust and consistent data handling, preventing potential errors and improving the reliability of data annotation workflows.

Highlights

• Numeric Identifier Handling: Implemented explicit conversion of numeric cell line and drug identifiers (G# and clid) to character type within annotation functions to prevent issues during data processing and matching.
• Package Version Update: The package version has been incremented from 1.9.5 to 1.9.6, reflecting the bug fix and new release.
• Changelog Entry: A new entry has been added to the NEWS.md file documenting the fix for handling numeric identifiers in annotation functions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• NEWS.md
  • fix handling of numeric identifiers in annotation functions

Activity

• The package version was bumped as part of the logistic checklist.
• The changelog was updated as part of the logistic checklist.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to enforce character types for G# and clid identifiers to prevent issues with numeric conversions. The changes involve adding checks and type conversions in various annotation functions. The overall approach is sound. My review focuses on improving consistency in the implementation. I've suggested using idiomatic data.table syntax for column modifications across all related functions to maintain a consistent coding style.