Gdr 3212

[bczech]

Description

What changed?

Related JIRA issue: GDR-3212

Why was it changed?

Checklist for sustainable code base

• I added tests for any code changed/added
• I added documentation for any code changed/added
• I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

• Package version bumped
• Changelog updated

Screenshots (optional)

[gemini-code-assist]

Summary of Changes

Hello @bczech, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the gDRimport package to version 1.9.4, primarily by enhancing its capability to process PRISM data. The key functional change involves integrating broad_id as a recognized identifier within the PRISM data import pipeline, ensuring more robust and consistent drug identification and mapping to Gnumber.

Highlights

• Version Update: The gDRimport package version has been incremented from 1.9.3 to 1.9.4.
• PRISM Data Enhancement: Added support for broad_id in PRISM data processing, allowing this identifier to be used for drug identification within the import pipeline.
• Data Column Mapping Refinement: Modified the internal mapping of columns during PRISM data conversion, specifically mapping broad_id to Gnumber and name to DrugName for improved data consistency and handling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for using broad_id from PRISM data as the primary drug identifier (Gnumber). The changes in R/prism_to_gdrDF.R are logical and correctly implement this feature, improving the clarity of the code. The package version and changelog have also been updated appropriately. However, the pull request lacks corresponding test updates to verify this new functionality, which is a crucial step to ensure correctness and prevent future regressions.

[j-smola]

Please, add some tests.

[gladkia]

Great job!